Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One degree simulation in the examples #276

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

simone-silvestri
Copy link
Collaborator

A couple of bugs have been fixed. Now the one degree is stable. To be correct we need to implement a PolarBoundaryCondition for JRA55 fields and the input bathymetry since they span (-90, 90) on a latitude-longitude grid.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (0fff4fa) to head (9ead323).

Files with missing lines Patch % Lines
src/OceanSimulations/OceanSimulations.jl 0.00% 16 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #276   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         33      33           
  Lines       1876    1891   +15     
=====================================
- Misses      1876    1891   +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navidcy navidcy requested a review from glwagner November 24, 2024 19:58
@simone-silvestri
Copy link
Collaborator Author

simone-silvestri commented Nov 28, 2024

I think it would be nice as the objective of this PR to have a working one degree simulation in the examples (probably it will take a while)

@simone-silvestri simone-silvestri changed the title One degree simulation take 3 One degree simulation in the examples Nov 28, 2024
@navidcy
Copy link
Collaborator

navidcy commented Dec 2, 2024

Should we include it in the literated examples?

@simone-silvestri
Copy link
Collaborator Author

simone-silvestri commented Dec 3, 2024

Should we include it in the literated examples?

I think that would be very nice. There are probably a lot of users that want to run a coarser version of the global simulation. I think the roadmap to get this simulation working as an example is as follows:

  • PRs #3965 and #3960 in Oceananigans
  • PR #59 in OrthogonalSphericalShellGrids
  • A working version of Redi (should come in #3901 in Oceananigans)
  • advective GM (PR #3971 in Oceananigans)

We could start including the simulation in the examples with the current GM which should work in terms of results, but it is very slow (see issue #3938 in Oceananigans)

Then, once we have sea ice coupled we should update the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants