-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One degree simulation in the examples #276
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 33 33
Lines 1876 1891 +15
=====================================
- Misses 1876 1891 +15 ☔ View full report in Codecov by Sentry. |
I think it would be nice as the objective of this PR to have a working one degree simulation in the examples (probably it will take a while) |
…into ss/one-degree-take3
Should we include it in the literated examples? |
I think that would be very nice. There are probably a lot of users that want to run a coarser version of the global simulation. I think the roadmap to get this simulation working as an example is as follows:
We could start including the simulation in the examples with the current GM which should work in terms of results, but it is very slow (see issue #3938 in Oceananigans) Then, once we have sea ice coupled we should update the example |
…into ss/one-degree-take3
A couple of bugs have been fixed. Now the one degree is stable. To be correct we need to implement a PolarBoundaryCondition for JRA55 fields and the input bathymetry since they span (-90, 90) on a latitude-longitude grid.